Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: es-419 --> es_419 to match Transifex code #1485

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: es-419 --> es_419 to match Transifex code #1485

merged 1 commit into from
Oct 10, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Oct 10, 2023 •
edited
Loading

Otherwise it's a faulty code. Also corrected in the Confluence table.

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023 •
edited
Loading

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi marked this pull request as ready for review October 10, 2023 09:13
shadinaif
shadinaif approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@shadinaif shadinaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OmarIthawi

@OmarIthawi OmarIthawi merged commit 89092fa into openedx:main Oct 10, 2023
5 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi OmarIthawi mentioned this pull request Oct 10, 2023
Merged
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadinaif shadinaif shadinaif approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarIthawi @openedx-webhooks @shadinaif @itsjeyd